refactor(swap): clean up Swap widget from isWrapOrUnwrap #2775
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Looks and works good 👍
Only one behaviour change from prod which might be a problem, but not a big one.
It's no longer possible to insert the receive amount when wrapping/unwrapping.
Yes, the amounts are exactly the same, it has no actual difference from inputting it on sell or buy, but raising it just in case.
There was a problem hiding this comment.
- Swap page:
- no waiting modal when run wrap/unwrap transaction
- not allowed to edit TO field's value
- Custom recipient field should be hidden when wrap/unwrap
- Limit orders:
- error loading price for unwrap/wrap
- also impossible to edit To field's value
- Custom recipient field should be hidden when wrap/unwrap
- Advanced: same comments as for Limit orders page (besides custom recipient field)
|
@elena-zh thanks! Fixed everything |
I did it intentionally to keep the code simple. I don't see any concrete reasons for this functionality |
|
Hey @shoom3301 , all is good, The last issue that I see that there is no balance check on Wrap/unwrap transaction. Could you please fix this as well? Wrap/unwrap button should be disabled when 'could not load balances' and 'insufficient balance' errors are happening. |
|
@elena-zh thanks! Fixed |
|
Hey @shoom3301 , the last nitpick: amount is reset to 0 when press on the change tokens arrow on the Swap page: |
|
@elena-zh thanks, fixed! |
… fix/2768-1 # Conflicts: # src/modules/tradeFormValidation/services/validateTradeForm.ts # src/pages/LimitOrders/index.tsx
| <TradeFormBlankButton onClick={context.wrapNativeFlow}> | ||
| <TradeFormBlankButton onClick={() => context.wrapNativeFlow()}> |
There was a problem hiding this comment.
Why do you need the wrapper fn?
Summary
Context: #2774
Removed
wrap/unwrapchecks from Swap page code, becausewrap/unwrapflow is consolidated inTradeWidget.To Test (Swap / Limit / Advanced)